Removing abort() from RE2 again because Google refuses to use exceptions #11458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
approved these changes
Apr 2, 2024
| if ((fncall) != 0) abort(); \ | ||
| } while (0) | ||
| if ((fncall) != 0) throw std::runtime_error("RE2 pthread failure"); \ | ||
| } while (0); |
There was a problem hiding this comment.
Do we want the trailing semicolon here?
Suggested change
| } while (0); | |
| } while (0) |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 5, 2024
Merge pull request duckdb/duckdb#11458 from hannes/zapabortre2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a CRAN check cc @krlmlr