Issue #11269: DISTINCT Sorted Aggregates #11321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should only be a allowed when the ordering expressions are in the argument list. Anything else is confusing and ambiguous. This is what PG does too. fixes: duckdb#11269 fixes: duckdblabs/duckdb-internal#1639
Fix invalid legacy test. fixes: duckdb#11269 fixes: duckdblabs/duckdb-internal#1639
Fix another incorrect test. fixes: duckdb#11269 fixes: duckdblabs/duckdb-internal#1639
Fix more tests. fixes: duckdb#11269 fixes: duckdblabs/duckdb-internal#1639
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11321 from hawkfish/distinct-sorted-aggs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should only be a allowed when the ordering expressions are in the argument list. Anything else is confusing and ambiguous. This is what PG does too.
fixes: #11269
fixes: duckdblabs/duckdb-internal#1639