Fix null pointer exception when rolling back updates if the rollback was caused by an OOM #11309
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was caused by an OOM
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11309 from Mytherin/updatenullrefrollback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a large update triggers an allocation failure/OOM, it is possible that we write an entry into the transaction log for a specific update, but never actually create that entry. In that case a null pointer exception would be triggered during the rollback, which assumed that the version info for the vector would have been present. This PR modifies the assertion into an actual check, and simply skips the clean-up in this scenario.