Improve binding of CTEs #11399
Merged
Improve binding of CTEs #11399
+71
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change FindCTE to return a vector of all candidate CTEs instead of just one CTE. This vector is used to implement a retry mechanism in bind_basetableref.cpp. Only if binding fails for all CTEs, the appropriate exception is thrown. Fixes duckdb#11391
|
Thanks for the PR! LGTM |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 2, 2024
Merge pull request duckdb/duckdb#11399 from kryonix/cte_fix Merge pull request duckdb/duckdb#11459 from carlopi/skip_ccache_r
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
FindCTEto return a vector of all candidate CTEs instead of just one CTE. This vector is used to implement a retry mechanism inbind_basetableref.cpp. Only if binding fails for all CTEs, the appropriate exception is thrown.Fixes #11391