Skip to content

Conversation

hawkfish
Copy link
Contributor

Change RESPECT/IGNORE NULLS to an enum so we can catch invalid usage.

fixes: #10965
fixes: duckdblabs/duckdb-internal#1458

Change RESPECT/IGNORE NULLS to an enum so we can catch invalid usage.

fixes: duckdb#10965
fixes: duckdblabs/duckdb-internal#1458
@hawkfish hawkfish requested a review from Mytherin March 26, 2024 20:55
@Mytherin Mytherin merged commit d4c2eca into duckdb:main Mar 28, 2024
@Mytherin
Copy link
Collaborator

Thanks! LGTM

@hawkfish hawkfish deleted the respect-ignore-nulls branch March 28, 2024 16:34
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 30, 2024
Merge pull request duckdb/duckdb#11372 from hawkfish/respect-ignore-nulls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sum( ... RESPECT NULLS) should throw error (and the docs shouldn't say that RESPECT NULLS is the default)
2 participants