Issue #10867: AsOf Predicate Pushdown #11233
Merged
+68
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement correct predicate pushdown for INNER AsOf joins. Since we do push them down for LEFT AsOf joins, this was especially unfortunate. fixes: duckdb#10867 fixes: duckdblabs/duckdb-internal#1382
taniabogatsch
approved these changes
Mar 19, 2024
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 20, 2024
Merge pull request duckdb/duckdb#11233 from hawkfish/asof-pushdown Merge pull request duckdb/duckdb#11265 from Mytherin/terminalmissingincludes
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 23, 2024
Merge pull request duckdb/duckdb#11233 from hawkfish/asof-pushdown Merge pull request duckdb/duckdb#11265 from Mytherin/terminalmissingincludes
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11233 from hawkfish/asof-pushdown Merge pull request duckdb/duckdb#11265 from Mytherin/terminalmissingincludes
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement correct predicate pushdown for INNER AsOf joins. Since we do push them down for LEFT AsOf joins,
this was especially unfortunate.
fixes: #10867
fixes: duckdblabs/duckdb-internal#1382