Fix #11211 - correctly fill in string_t padding for bit type #11231
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 19, 2024
Merge pull request duckdb/duckdb#11231 from Mytherin/bitverify
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 23, 2024
Merge pull request duckdb/duckdb#11231 from Mytherin/bitverify
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11231 from Mytherin/bitverify
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11231 from Mytherin/bitverify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11211
Bits are internally represented as
string_t- meaning this struct needs to be filled in correctly by callingstring_t::Finalize(). Not doing so has no effect on bit operations, but can cause operations on the underlyingstring_t(like equality) to be incorrect.