Flatten Rewrite #11223
Merged
Flatten Rewrite #11223
+66
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taniabogatsch
approved these changes
Mar 18, 2024
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 18, 2024
Merge pull request duckdb/duckdb#11223 from maiadegraaf/verify_vector_flatten Merge pull request duckdb/duckdb#11225 from Mytherin/juliabumpandfix Merge pull request duckdb/duckdb#11218 from Mytherin/disablejemalloconarm Merge pull request duckdb/duckdb#11217 from carlopi/fix_python_and_extensions Merge pull request duckdb/duckdb#11212 from carlopi/review_ci_on_tags
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 23, 2024
Merge pull request duckdb/duckdb#11223 from maiadegraaf/verify_vector_flatten Merge pull request duckdb/duckdb#11225 from Mytherin/juliabumpandfix
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 23, 2024
Merge pull request duckdb/duckdb#11223 from maiadegraaf/verify_vector_flatten Merge pull request duckdb/duckdb#11225 from Mytherin/juliabumpandfix
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11223 from maiadegraaf/verify_vector_flatten
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 28, 2024
Merge pull request duckdb/duckdb#11223 from maiadegraaf/verify_vector_flatten Merge pull request duckdb/duckdb#11225 from Mytherin/juliabumpandfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11138 introduced new verification methods that resulting in
flatten()producing the incorrect result whenVERIFY_VECTOR=nested_shuffle.This prompted a complete rewrite of
flatten(), now it builds a selection vector based on the offset and lengths of the original vector and then slices the child of the original vector onto the result vector.