fix(jdbc): support fractional seconds in getTime #10707
Merged
+54
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
approved these changes
Feb 16, 2024
| return null; | ||
| } | ||
|
|
||
| if (isType(DuckDBColumnType.TIME)) { |
There was a problem hiding this comment.
Should this handle TIME_TZ too?
There was a problem hiding this comment.
I don't think it really makes sense to handle TIME_TZ in the getLocalTime method?
hawkfish
approved these changes
Mar 4, 2024
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 17, 2024
Merge pull request duckdb/duckdb#11072 from Mytherin/parquetprogress Merge pull request duckdb/duckdb#10707 from Mause/bugfix/jdbc-get-time Merge pull request duckdb/duckdb#10831 from krlmlr/f-ext-patch Merge pull request duckdb/duckdb#11070 from mariotaddeucci/code-quality-pep8-compliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up some TODO's I left a while back
Fixes #10682