Skip to content

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Jan 24, 2024

This PR fixes issues with:

  1. The Progress Bar. We were not correctly taking bytes_read into account.
  2. Error Handling. A deadlock could happen when trying to handle errors from different threads. This PR loses the locks a bit and adds a sync variable to terminate hanging threads.
  3. Adds the test/sql/copy/csv/parallel/csv_parallel_clickbench.test_slow back. At some point, this test was removed from the CI. I guess was just forgotten. I've fixed it up and made sure it runs again.

Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good - one comment:

@github-actions github-actions bot marked this pull request as draft January 24, 2024 14:41
@pdet pdet marked this pull request as ready for review January 25, 2024 14:03
@github-actions github-actions bot marked this pull request as draft January 26, 2024 10:25
@pdet pdet closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants