Skip to content

Conversation

maiadegraaf
Copy link
Contributor

SQLColAttribute tests have been moved to a new directory. Now we have a file for general tests, as well as a file that tests all the SQLColAttribute fields for both SQL_VARCHAR and SQL_INTEGER. These can be easily expanded to include all the SQL types, in the future.

@github-actions github-actions bot marked this pull request as draft November 7, 2023 09:08
@maiadegraaf maiadegraaf marked this pull request as ready for review November 7, 2023 09:08
Copy link
Contributor

@taniabogatsch taniabogatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had two questions, see my comments below.

@github-actions github-actions bot marked this pull request as draft November 8, 2023 15:58
@maiadegraaf maiadegraaf marked this pull request as ready for review November 8, 2023 16:00
@github-actions github-actions bot marked this pull request as draft November 8, 2023 16:02
@maiadegraaf maiadegraaf marked this pull request as ready for review November 8, 2023 19:58
Copy link
Contributor

@taniabogatsch taniabogatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick comment, otherwise looks much better now!

@github-actions github-actions bot marked this pull request as draft November 9, 2023 13:38
@maiadegraaf maiadegraaf marked this pull request as ready for review November 9, 2023 14:13
@Mytherin Mytherin merged commit 3a9c632 into duckdb:main Nov 10, 2023
@Mytherin
Copy link
Collaborator

Thanks

@maiadegraaf maiadegraaf deleted the col_attr_test_reorg branch February 23, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants