Fixing "No exported functions in windows dll" issue #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thank you. Will merge once tests pass. |
|
Nevermind the R OSX failure its a bit flaky. I restarted it. |
hannes
reviewed
Sep 21, 2020
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Dec 21, 2023
Fix compiler snark.
Mytherin
added a commit
that referenced
this pull request
Dec 22, 2023
Internal #940: GCC Window Distinct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch is related to issue #934
This patch only exposes the C API of duckdb via DLL