-
Notifications
You must be signed in to change notification settings - Fork 2.6k
TPC-H Extension #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TPC-H Extension #873
+17,900
−17,505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them in the catalog like other functions
…ing expected results from a CSV file
…hmarks for verification purposes, and add TPC-H queries back using interpreted benchmarks
… to parquet writer
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
Dec 8, 2023
We have been assuming that empty aggregate frames always produce NULL, but as this example shows, this is not always true. The test file verifies the behaviour for all aggregates, and will fail if a new aggregate is added, prompting a new test. fixes: duckdblabs/duckdb-internal#873 fixes: duckdblabs/huawei#5
Mytherin
added a commit
that referenced
this pull request
Dec 11, 2023
Internal #873: Empty Aggregate Frames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the TPC-H module into a proper extension. The extension can be build by setting the
BUILD_TPCH_EXTENSION
flag in the cmake config. When compiled in, it is included by default in the shell. The extension provides the following SQL support:To enable this, the PR includes support for procedures (e.g. CALL x()) and now stores PRAGMA functions in the catalog, rather than having them be hard-coded into the engine. The interpreted benchmarks are also extended to now support loading results from a file,
cleanup
andinit
scripts,require
for requiring extensions (like the sqllogictests) and benchmark templates (allowing a templated script to run another benchmark script with some string substitutions, see e.g. the TPC-H SF1 queries in benchmark/tpch/sf1/q...).