Skip to content

Fix TupleDataCollection List serialization #7741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2023
Merged

Fix TupleDataCollection List serialization #7741

merged 3 commits into from
May 31, 2023

Conversation

lnkuiper
Copy link
Contributor

I thought I fixed this when I fixed duckdb/duckdb-fuzzer#132, but then duckdb/duckdb-fuzzer#135 popped up.

The problem was with nested lists. If we have this:

LIST (        // a
    LIST (    // b
        INT   // c
    )
)

I was computing the size of c without ever using b, which was obviously wrong.

This change also fixes #7667

@Mytherin Mytherin merged commit e08e74a into duckdb:master May 31, 2023
@Mytherin
Copy link
Collaborator

Thanks for the PR! Looks great.

@lnkuiper lnkuiper deleted the tdc_fixes branch June 26, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lnkuiper @Mytherin