Code Coverage CI check - allow one uncovered line #7724
Merged
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Code Coverage CI is often failing with a single missing uncovered line in different unrelated files. I have investigated a few of them and the ones I investigated are inexplicable - i.e. the line should have been covered by the tests. I am unsure if this is caused by random behavior in the tests ("race conditions" on which lines are covered due to multi-threading) or due to a bug in the code coverage tool. In order to avoid too many unnecessary breakage of the Code Coverage CI too much we allow a single uncovered line to exist in total.