Fix #7659 - use correct catalog when replaying a CREATE TABLE in the WAL #7675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ERIFY is enabled
…hat we don't always checkpoint on shutdown - and fix issue with WAL playback of index creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7659
In addition, we disable the
checkpoint_on_shutdownwhenDUCKDB_ALTERNATE_VERIFYis enabled. This should trigger the WAL replay in many more tests. This extra testing found two additional problems with WAL replay of enums andCREATE INDEXstatements - which are also fixed in this PR.