Generate default_types from json files
#7646
Merged
+450
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
suggested changes
May 23, 2023
|
We might also be able to use this list for |
Mytherin
reviewed
May 25, 2023
src/include/duckdb/catalog/default/builtin_types/fixed_point.json
Outdated
Show resolved
Hide resolved
| namespace duckdb { | ||
|
|
||
| const case_insensitive_map_t<LogicalTypeId> &GetInternalTypes() { | ||
| static const std::pair<std::string, LogicalTypeId> types[] = { |
There was a problem hiding this comment.
Can this use the DefaultType struct that was used previously?
It likely doesn't really matter but this is keeping a lot more data and more complex structures with destructors statically allocated than before.
There was a problem hiding this comment.
I turned it into a std::array instead now
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to keep type-related docs up to date.