[ADBC] Transactions and explicitly not-supporting Partition Reading/Execution #7639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xplicitly not supporting partitions functions
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds implements the
ConnectionCommitandConnectionRollbackfunctions. It also includes support to switchADBC_CONNECTION_OPTION_AUTOCOMMITon and off, which is on by default.In addition,
ADBC_INGEST_OPTION_TARGET_TABLEis extended to detect if the table already exists automatically and either create the table if it doesn't or ingest in the existing table, as described in the ADBC docsConnectionReadPartitionandStatementExecutePartitionsare also properly added as unsupported functionality.