Skip to content

Fix #7564 - if the auto-complete extension is not enabled, inline it into the shell #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

Fix #7564 - if the auto-complete extension is not enabled, inline it into the shell #7621

merged 1 commit into from
May 23, 2023

Conversation

Mytherin
Copy link
Collaborator

Fixes #7564

@Mytherin Mytherin requested a review from Mause May 22, 2023 13:51
@Mytherin Mytherin mentioned this pull request May 22, 2023
Closed
2 tasks
@adriens
Copy link

adriens commented May 22, 2023

🙆‍♂️

@Mause
Copy link
Member

Mause commented May 23, 2023 •
edited
Loading

I'm not sure I follow how this fixes the issue on non-brew builds? The extension is there and loaded, but for whatever reason does not work

@Mytherin
Copy link
Collaborator Author

It works for me when the extension is present. Have you verified that it doesn't work in your build?

@Mytherin Mytherin merged commit 52bce12 into duckdb:master May 23, 2023
@adriens
Copy link

adriens commented May 23, 2023

I'l test it as soon as there is a new release (I installed duckdb with brew)

@Mytherin Mytherin mentioned this pull request May 23, 2023
Merged
@Mytherin Mytherin deleted the issue7564 branch July 5, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mause Mause Awaiting requested review from Mause

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 No more autocomplete on v0.8.0
3 participants
@Mytherin @adriens @Mause