Fix Julia BoundsError with arrays > 2048 #7055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brb with tests (EDIT: done) |
f95872b to
e99192e
Compare
e99192e to
3a38289
Compare
When mapping regions of memory to Julia, typically it is modelled as an array including an extent. Currently, this was always VECTOR_SIZE = 2048, however child elements of array-like data structures can have data with larger extents. This commit uses the actual extent for these variable sized data structures.
3a38289 to
d975649
Compare
|
Thanks for the PR! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6924
When mapping regions of memory to Julia, typically it is modeled as an array including an extent. Currently, this was always VECTOR_SIZE = 2048, however child elements of array-like data structures can have data with larger extents. This commit uses the actual extent for these variable sized data structures.