[External Buffer Manager] Step1: Split components from buffer_manager.cpp
#7028
+474
−413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a small question for my own learning (and maybe to then advertise this new feature!). Where can we use an external buffer manager? Would this work as a buffer for parquet files (local and/or remote?)? That would be a pretty exciting feature for a number of folks I think! Or is this for a totally different purpose? |
|
I believe this is only relevant for integrating with a system that has its own buffer-manager-like system, DuckDB can then share the buffer pool of the other system, instead of both fighting for system resources And this PR in particular does nothing to enable this, I'm just cutting up the mentioned PR so it's easier to oversee the changes |
|
@Mytherin can you please rerun the failed codecov run? |
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first step of the steps proposed in #5683 #5683 (comment)
Not changing any logic yet, just moving separate components that have become quite large to their own files