Skip to content

[Python] Fix datetime with tzinfo converting to naive TIMESTAMP #7024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2023
Merged

[Python] Fix datetime with tzinfo converting to naive TIMESTAMP #7024

merged 2 commits into from
Apr 11, 2023

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Apr 11, 2023 •
edited
Loading

This PR fixes #6466

When converting the datetime.datetime object, we already stripped the timezone, but didn't save the value as being of the type TIMESTAMPTZ

Mause
Mause reviewed Apr 11, 2023
View reviewed changes
@Mytherin Mytherin merged commit 65a56c6 into duckdb:master Apr 11, 2023
@davetapley
Copy link

@Tishj I just got around to testing this on 0.8.0 and it doesn't appear to have resolved the issues I raised on this comment: #6466 (comment), specifically the implicit cast to UTC but still returning a naive Python datetime.

Just wanted to confirm before I open a new issue.

@Mytherin
Copy link
Collaborator

@Tishj I just got around to testing this on 0.8.0 and it doesn't appear to have resolved the issues I raised on this comment: #6466 (comment), specifically the implicit cast to UTC but still returning a naive Python datetime.

Just wanted to confirm before I open a new issue.

Feel free to open a new issue, I think that hasn't been implemented yet and it might get lost otherwise

@davetapley davetapley mentioned this pull request Oct 26, 2023
Closed
1 task
@davetapley
Copy link

I don't see anything specific in the 0.9.0 release notes, but as a heads up: I just went from 0.8.0 to 0.9.0 and I'm now seeing this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Mause Mause Mause left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] datetime -> [duckdb] timestamptz conversion error
4 participants
@Tishj @davetapley @Mytherin @Mause