Skip to content

feat(jdbc): stringify nested types #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 9, 2023
Merged

feat(jdbc): stringify nested types #7000

merged 7 commits into from
Apr 9, 2023

Conversation

Mause
Copy link
Member

@Mause Mause commented Apr 7, 2023

It looks like DBeaver is smart enough to parse lists into a format it can decompose, without any further work, though maps and structs are left as is.

This will probably fulfill most people's requirements for nested types in the JDBC driver

Screenshot_2023-04-08_00-24-40

Mytherin
Mytherin reviewed Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Great to get this working, and nice that DBeaver handles this smoothly even as strings. Some comments:

@Mause Mause requested a review from Mytherin April 9, 2023 08:46
@Mytherin Mytherin merged commit bacede9 into duckdb:master Apr 9, 2023
@Mytherin
Copy link
Collaborator

Mytherin commented Apr 9, 2023

Thanks for the fixes! LGTM

@Mause Mause mentioned this pull request Apr 9, 2023
Open
@Mause Mause deleted the feature/jdbc-stringify-nested-types branch April 11, 2023 09:40
This was referenced Apr 17, 2023
Closed
Closed
Closed
Closed
Closed
@lukaseder lukaseder mentioned this pull request Apr 18, 2023
Closed
@Mause Mause mentioned this pull request Apr 19, 2023
Closed
2 tasks
@Jack-Corbett
Copy link

Excellent work @Mause can't thank you enough for fixing this! @Mytherin do you know when this will make it to release?

@Mytherin
Copy link
Collaborator

The next release is planned for mid May

@lukaseder
Copy link

As I've commented in #7173, I think that the current next-version String representation of arrays is going to be insufficient for formal tool support. Even Dbeaver can't distinguish between array['a', 'b'] and array['a, b'], so more formal JDBC Array and Struct support would be helpful here.

image

@LonwoLonwo LonwoLonwo mentioned this pull request May 8, 2023
Closed
@Mause Mause mentioned this pull request May 16, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Awaiting requested review from Mytherin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mause @Mytherin @Jack-Corbett @lukaseder