Issue #5290: Rewrite ordered LIST #6741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2023 14:44
Move the linked list code out for reuse.
Rewrite the pattern LIST(x ORDER BY x <ordering>) as LIST_SORT(LIST(x), <ordering>). This reduces the included benchmark run time from 23.5s to 4.32s.
added 2 commits
March 15, 2023 15:26
Add missing include for tidy.
Mytherin
reviewed
Mar 16, 2023
There was a problem hiding this comment.
Thanks for the PR! Looks great. Can we also add some tests for this behavior? For example, some optimizer tests that look at the plan to verify the optimization is performed - but also tests with different ORDER BY constructs to verify the result is still correct after optimization (e.g. different mixes of ORDER BY x, ORDER BY x DESC, ORDER BY x DESC NULLS LAST, etc)?
added 5 commits
March 20, 2023 11:21
Correct benchmark description.
Add more strings to EnumSerializer so LIST_SORT can use it for parsing.
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the pattern
LIST(x ORDER BY x <ordering>)asLIST_SORT(LIST(x), <ordering>). This reduces the included benchmark run time from 23.5s to 4.32s.