Skip to content

feat(nodejs): Expose HTTPException as HTTPError #6655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Mar 14, 2023
Merged

feat(nodejs): Expose HTTPException as HTTPError #6655

merged 31 commits into from
Mar 14, 2023

Conversation

Mause
Copy link
Member

@Mause Mause commented Mar 10, 2023

Also adds support for "http reason", and headers

Mause added 28 commits March 9, 2023 19:11
@Mause
chore: restore template
9ccef9c
@Mause
feat: add headers to HTTPException
c190f88
@Mause
feat: expose http reason
ebee091
@Mause
refactor: rename response to response_body
9f75c68
@Mause
test: add test for failed extension installation
451419a
@Mause
test: fix assertion
2949ea1
@Mause
chore: fix another assertion
ef4300c
@Mause
chore: restore template
f719969
@Mause
test: add test for HTTPException in js
67881db
@Mause
fix: format
a7a1a12
@Mause
fix: add type guard
b2dfb01
@Mause
chore(nodejs): switch to cast
c8300be
@Mause
chore: switch to cast
a587d3f
@Mause
chore: expose response to nodejs
f8963f9
@Mause
chore: add response to type stubs
085e830
@Mause
fix some tests
8eab5d3
@Mause
chore: expose reason and headers
2712458
@Mause
chore: remove dud method call
3ed4627
@Mause
fix: format
3531558
@Mause
chore: add reason and headers to type stubs
10205d4
@Mause
fix: add jsdoc types for HTTPError
2d37c13
@Mause
chore: add body to ResponseWrapper
034f2cd
@Mause
test: update nodejs assertions
f352e05
@Mause
test: update assertion
f48e102
@Mause
Merge branch 'master' into feature/http-exception
a7c705b
@Mause
chore: update python stubs for HTTPException
d1c4336
@Mause
docs(python): add dunder annotations and doc to HTTPException
d555a22
@Mause
fix: format
6a7e762
Mytherin
Mytherin reviewed Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks great. One comment:

@Mytherin Mytherin merged commit 8aea455 into duckdb:master Mar 14, 2023
@Mause Mause deleted the feature/http-exception branch March 14, 2023 09:58
@Tishj Tishj mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mause @Mytherin