R: Fix protection errors for relational API #6469
Merged
+66
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8ebf68 to
9fc219d
Compare
hannes
reviewed
Feb 27, 2023
| } | ||
|
|
||
| [[cpp11::register]] SEXP rapi_rel_set_diff(duckdb::rel_extptr_t rel_a, duckdb::rel_extptr_t rel_b) { | ||
| auto res = std::make_shared<SetOpRelation>(rel_a->rel, rel_b->rel, SetOperationType::EXCEPT); | ||
| return make_external<RelationWrapper>("duckdb_relation", res); | ||
|
|
||
| cpp11::writable::list prot = {rel_a, rel_b}; |
There was a problem hiding this comment.
Looks good, but can't we do the list wrapping in make_external_prot, too?
There was a problem hiding this comment.
Does this mean passing two arguments to make_external_prot(), or just inlining the prot variable?
There was a problem hiding this comment.
I was thinking of the latter but not sure if it still shows the desired behaviour
There was a problem hiding this comment.
I suspect it would, the temporary list won't be destroyed for the duration of the make_external()call, and hece will remain protected. We can try in a second iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6465.
This adds a tiny change to the vendored cpp11 code, we should eventually upstream it to take advantage of future updates.