Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5685
The addition of presigned s3 urls caused some complications that broke the s3 upload. Somehow minio handles url encoding slightly differently which is why we didn't catch it.
Changes made to fix it:
s3_url_compatibility_mode
option that can be set to disable query params and globs on s3 urls.While simply disallowing '?' in s3 urls may seem a bit crude, we already did not really support them well as they would be seen as glob characters and would be able to cause unexpected behaviour.
To in short:
By default, Globbing and Query params for fully qualified urls are enabled
optionally, you can use the compatibility mode to reach those hard to reach places
If you were using ? in globs on s3 urls, the workaround is to use the
[abcde]
notation to catch single characters.