Skip to content

Java: Use automatic resource management for AutoCloseable types #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

Java: Use automatic resource management for AutoCloseable types #6377

merged 1 commit into from
Feb 21, 2023

Conversation

MariusVolkhart
Copy link
Contributor

Less code, and more correct, since a failure to close one resource doesn't prevent the other from closing.

@MariusVolkhart
Java: Use automatic resource management for AutoCloseable types
7e1867b 
Less code, and more correct, since a failure to close one resource doesn't prevent the other from closing.
Mytherin
Mytherin reviewed Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good - one comment:

@Mytherin Mytherin merged commit 915b15c into duckdb:master Feb 21, 2023
@MariusVolkhart MariusVolkhart deleted the mv/closeResources branch February 21, 2023 14:14
@MariusVolkhart MariusVolkhart mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariusVolkhart @Mytherin