JDBC - Add separate treatment for timestamptz values #6364
Merged
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like DuckDB's Value::TIMESTAMP behavior changed if used for TIMESTAMPTZ columns. The test case was failing.
This PR adds a Subclass (without any additional logic) named DuckDBTimestampTZ. It is created if a OffsetDateTime is used in the setObject method, signaling the need for a timezone. Later on it is possible to distinguish in the JNI code between Value::TIMESTAMP and Value::TIMESTAMPTZ depending on which Java object was handed over.
One of my older test cases had quite a long runtime. I used the opportunity to shorten it about one magnitude.