Skip to content

Conversation

xcaptain
Copy link
Contributor

  1. ensure timezone can be set
  2. added some examples on querying timestamp and timestamptz

1. ensure timezone can be set
2. added some examples on querying timestamp and timestamptz
@xcaptain xcaptain mentioned this pull request Feb 17, 2023
2 tasks
@Mytherin
Copy link
Collaborator

Thanks for the PR. The PR title is not descriptive of what is changed here. Also, could you please ensure the CI passes on your fork prior to opening a PR?

@xcaptain
Copy link
Contributor Author

xcaptain commented Feb 18, 2023

Sorry, didn't realized these CIs runs so long, will check first locally then submit PR in the future. I made some changes, now format check passed, and unit test passed in nightly.
julia 1.6 and 1.7 failed, the reason is julia 1.6 is not built with ubuntu-latest so has a different GLIBCXX version with libduckdb.so

ERROR: LoadError: could not load library "/home/runner/work/duckdb/duckdb/build/release/src/libduckdb.so"
/opt/hostedtoolcache/julia/1.7.3/x64/bin/../lib/julia/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by /home/runner/work/duckdb/duckdb/build/release/src/libduckdb.so)

@xcaptain
Copy link
Contributor Author

Since JuliaPackaging/Yggdrasil#6282 was merged, we also need to update DuckDB_Jll's version at https://github.com/duckdb/duckdb/blob/master/tools/juliapkg/Project.toml#L10 for use where JULIA_DUCKDB_LIBRARY is not set.

@xcaptain xcaptain changed the title add some test cases Julia: Support change timezone config Feb 18, 2023
By default julia should have bundled a libstdc++ in
a place like `/usr/lib/julia/libstdc++.so.6`, while
`libduckdb.so` is built with system's glibc usually
in `/usr/lib/x86_64-linux-gnu/libstdc++.so.6`, set
the `LD_PRELOAD` variable may let julia and duckdb use
the same version of glibc to avoid errors like

```
ERROR: LoadError: could not load library "/home/runner/work/duckdb/duckdb/build/release/src/libduckdb.so"
/opt/hostedtoolcache/julia/1.7.3/x64/bin/../lib/julia/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by /home/runner/work/duckdb/duckdb/build/release/src/libduckdb.so)
```
@Mytherin Mytherin merged commit 55fd761 into duckdb:master Feb 20, 2023
@Mytherin
Copy link
Collaborator

Thanks

@xcaptain xcaptain deleted the feature/add-tests-about-timezones branch February 21, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants