JDBC: Expand Blob, add UUID support #6302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach the ResultSet#getObject(int) method to return Blob type.
Teach the ResultSet#getObject(int) method to return UUID type.
MariusVolkhart
commented
Feb 15, 2023
| stmt.execute("CREATE TABLE t (id INT, b UUID)"); | ||
| stmt.execute("INSERT INTO t VALUES (1, uuid())"); | ||
| stmt.execute("CREATE TABLE t (id INT, b INTEGER[])"); | ||
| stmt.execute("INSERT INTO t VALUES (1, [2, 3])"); |
There was a problem hiding this comment.
Had to modify this test to a different column type since UUIDs no longer throw
|
Thanks for the PR! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JDBC's
ResultSet#getObject()method previously did not returnBlobcolumns, thoughBlobsupport was already part of theResultSet. The first commit adds support forBlobtogetObject().The
ResultSetalso didn't have support for UUID columns. These columns resulted in a "Unsupported result column type" exception. The second commit adds support for marshaling UUIDs from C++ to Java, modifiedResultSet#getObject()to returnjava.util.UUIDfor those columns, and adds a publicgetUuid()method for retrieving the column without a cast. UUID columns are marshaled efficiently using byte representations, butVARCHARcolumns can also be interpreted as UUIDs, matching behavior of othergetType()style functions.