Skip to content

Python: Make duckdb.sql return results for non-select queries in the form of a ValueRelation #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2023
Merged

Python: Make duckdb.sql return results for non-select queries in the form of a ValueRelation #6196

merged 4 commits into from
Feb 11, 2023
+79 −14

Conversation

Mytherin
Copy link
Collaborator

This makes queries like duckdb.sql('explain ...') actually return their results instead of swallowing them.

@Mytherin Mytherin requested review from Tishj and Mause February 10, 2023 13:25
Tishj
Tishj reviewed Feb 10, 2023
View reviewed changes
@Mytherin Mytherin merged commit 6b7db64 into duckdb:master Feb 11, 2023
@Mytherin Mytherin deleted the duckdbsqlresult branch February 16, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mause Mause Awaiting requested review from Mause

1 more reviewer

@Tishj Tishj Tishj left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mytherin @Tishj