Skip to content

Conversation

rpbouman
Copy link
Contributor

@rpbouman rpbouman commented Feb 10, 2023

fixes #6159

Added test for DatabaseMetaData.getTableTypes()
Test reproduces #6159
getTableTypes now returns a static list.

Test reproduces #6159
Also, fix #6159: getTableTypes now returns a static list.
@rpbouman
Copy link
Contributor Author

I'll pick it up later today. Test ran succesful for me, I will find out why there was a different result and fix it.

Renamed test for DatabaseMetaData.getTableTypes to adhere to naming convention
Modify test for DatabaseMetaData.getTableTypes to explitlyu check for order of the result.
@Tishj
Copy link
Contributor

Tishj commented Feb 10, 2023

Thanks for the PR!
I have one small nit: can you change the description to include fixes #6159
That way it automatically closes the referenced issue, not only mention it

@rpbouman rpbouman changed the title fix https://github.com/duckdb/duckdb/issues/6159 fixes #6159 Feb 10, 2023
@rpbouman
Copy link
Contributor Author

Thanks for the PR! I have one small nit: can you change the description to include fixes #6159 That way it automatically closes the referenced issue, not only mention it

Sure! I'll think about that for the next time. I hope I changed it correctly here for now. Let me know if not and I'll try again.

@Mytherin Mytherin merged commit 3ee9cbb into duckdb:master Feb 10, 2023
@Mytherin
Copy link
Collaborator

Thanks!

@rpbouman rpbouman deleted the issue-6159-duckdbj-DatabaseMetaData-getTableTypes-return-static-list branch February 10, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants