Fix Python deadlock - execute all PyRelations through the shared execute loop, and throw exception if Pandas Scan is called while GIL is held #6186

Mytherin · 2023-02-10T07:22:08Z

Executing all relations through a common interface will also allow cancellation of write_csv, etc using Ctrl+C.

We also add an exception to pandas_scan so if it is called while the GIL is held an exception is thrown.

…ute loop, and throw exception if Pandas Scan is called while GIL is held

Fix Python deadlock - execute all PyRelations through the shared exec…

a6c5151

…ute loop, and throw exception if Pandas Scan is called while GIL is held

Mytherin requested a review from Tishj February 10, 2023 07:22

Mytherin merged commit 33d17b8 into duckdb:master Feb 10, 2023

Mytherin deleted the pythondeadlock branch February 16, 2023 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Python deadlock - execute all PyRelations through the shared execute loop, and throw exception if Pandas Scan is called while GIL is held #6186

Fix Python deadlock - execute all PyRelations through the shared execute loop, and throw exception if Pandas Scan is called while GIL is held #6186

Uh oh!

Mytherin commented Feb 10, 2023 •

edited

Loading

Uh oh!

Uh oh!

Fix Python deadlock - execute all PyRelations through the shared execute loop, and throw exception if Pandas Scan is called while GIL is held #6186

Fix Python deadlock - execute all PyRelations through the shared execute loop, and throw exception if Pandas Scan is called while GIL is held #6186

Uh oh!

Conversation

Mytherin commented Feb 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Mytherin commented Feb 10, 2023 •

edited

Loading