Issue #3423: Positional Join Operator #5867
Merged
+15,509
−14,893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 2, 2023 14:45
Add new POSITIONAL JOIN join type and plumb it through to a straw man physical implementation.
Simple benchmark joining two integer columns. This is 2x faster than a hash join on rowid.
Add a second physical operator that manges two table scans.
make format-head doesn't work unless you have added the files...
Special case rendering of physical positional scans to display the internal tables.
Test (and fix) ragged PJ implementation.
Rename files for consistency.
Change positional scanning to have outer join semantics( NULL padding).
Change positional joining to have outer join semantics (NULL padding).
Add NULL propagation to all columns of a PJ.
added 4 commits
January 10, 2023 09:16
Mytherin
reviewed
Jan 12, 2023
src/include/duckdb/execution/operator/join/physical_positional_join.hpp
Outdated
Show resolved
Hide resolved
src/include/duckdb/planner/operator/logical_positional_join.hpp
Outdated
Show resolved
Hide resolved
added 10 commits
January 12, 2023 08:22
It's not a parallel sink...
Move all the join-type table refs into JoinRef to reduce code bloat.
Derive PJ and CP from a common base class.
Test multiple column joins with a single-table TPC-H query.
…into positional-join
Fix formatting that slipped though.
|
Thanks for the updates! Could you just merge with master and have a look at the remaining failing CI runs? |
added 6 commits
January 18, 2023 10:04
Another formatting vs merge issue.
Initialise type to INNER like JoinRef does.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new row-by-row join operator between two relations with
OUTERsemantics calledPOSITIONAL JOINPOSITIONAL.PositionalJoinRef.LogicalPositionalJoin.PhysicalPositionalJointo implement joins between relationsPhysicalPositionalScanto implement joins between table scans.fixes #3423