[Python] Changed use of DuckDBPyConnection to shared_ptr #5635
+82
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because of our intent to change the default connection.
As described here https://pybind11.readthedocs.io/en/stable/advanced/smart_ptrs.html#std-shared-ptr
when using shared_ptrs with pybind, you should also return them as shared pointers, or pybind will wrap it in a shared_ptr and that can cause undefined behavior
This change was previously part of another PR, which has now been closed.
After this PR is merged I can submit the PR to add all methods of DuckDBPyConnection to the 'duckdb' module