[Substrait] C API + from_substrait_json + bump on substrait version. #5613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
reviewed
Dec 6, 2022
| #' It interprets and executes the query. | ||
| #' | ||
| #' @param conn A DuckDB connection, created by `dbConnect()`. | ||
| #' @param json The Json Query Plan. Qack! |
There was a problem hiding this comment.
Suggested change
| #' @param json The Json Query Plan. Qack! | |
| #' @param json The Json Query Plan. Quack! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the substrait calls that already existed in the Python/R APIs to the C API.
It also adds the
from_substrait_jsonto all 3 APIs.The tests for all of this have been added on the following PR:
substrait-io/duckdb-substrait-extension#17
Note that for that PR to pass, this first needs to be merged.