Allow strings in ColumnDataCollection to be written to disk #5543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Nov 30, 2022
|
I fixed some CI issues, but now there is a stack overflow in one of the python windows tests. I suspect it is unrelated, but I can investigate if need be. |
|
Test passed this time, all green now |
|
Thanks for the updates! LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer use the
StringHeapwhen using the buffer manager allocator. When strings are read, we check if the pointers are still valid. If they are, we read as usual. If not, we will correct them. This should give around the same performance as theStringHeapif strings are not spilled, and only very slight overhead when they have not been spilled. This is realized by keeping track of just a little bit of meta data.Strings that are larger than
Storage::BLOCK_SIZEare written a single non-standard size block.As a bonus, I've also parallelized unswizzling strings in the
RowDataCollectionfor the hash join. This was the last part of the hash join that was not fully parallel.