Decimal values now round when the value given has more decimals than the scale of the target
#5362
+73
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/positive exponent, also added a RoundInfo struct to DecimalCastData to determine if the final decimal value should be rounded or not
…ndInfo struct out of DecimalCastData
2 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5288
Previously we were just ignoring all decimal values that exceeded the scale of the DECIMAL type, now we figure out if the final result should be rounded based on the first decimal value that exceeds the scale.
Working on this, I have uncovered an issue related to String -> Decimal with exponent and decimals
Issue is here: #5392