Fix binder error and produce more informative error message. #5302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnkuiper
reviewed
Nov 11, 2022
There was a problem hiding this comment.
This fix seems fine to me (if this doesn't break any other tests)
Although, I wonder what happens if you do:
SELECT avg(0) c0, (SELECT 0 OFFSET c0 + 1);Will your check still trigger? Since the offset is now no longer a BOUND_COLUMN_REF, but rather an expression. Maybe it still triggers because recursively the colref is bound anyway
Mytherin
reviewed
Nov 17, 2022
| statement error | ||
| SELECT avg(0) c0, (SELECT 0 OFFSET c0 + 1); | ||
| ---- | ||
| Parser Error: Non-constant limit or offset not supported in correlated subquery |
There was a problem hiding this comment.
The same error happens if we leave out the offset, e.g.:
D select avg(0) AS c0, (SELECT c0);
Error: INTERNAL Error: Failed to bind column reference "c0" [2.0] (bindings: [15.0])Could you test that that is fixed as well?
There was a problem hiding this comment.
@Mytherin added a test case for this, it's fixed as well!
https://github.com/Tmonster/duckdb/blob/22ee675570ec52e4fd254dc932456686b2ea1541/test/fuzzer/pedro/another_binder_error.test#L27
…g as h2oai also makes an https call to github. Maybe the plan_cost_runner doesnt compile duckdb with httpfs?
|
Thanks! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address fuzzer issue 48 in #4978
Originally an
INTERNAL ERROR: BINDER ERRORmessage was thrown, which I don't think is the most informative message to show users. Especially theINTERNAL ERRORBindCorrelatedColumnsgets called.ExtractCorrelatedExpressions, should then extract the correlated column/alias into the binder context but this doesn't happen.bound_colref.depth > 0inExtractCorrelatedExpressionsis false while the depth of the column c0 is very much 1.BindDelimiter()inbind_select_node.cpp, which callsexpr_binder.Bind(delimiter);which callsauto error_msg = Bind(&expr, 0, root_expression);inexpression_binder.cpp. The 0 is the depth.I'm not sure if this is the best fix though, as it feels like it could mess up other logic that uses the same code path. Maybe a nicer fix would be passing the depth to the
BindDelimiterand keep passing it along? Open to other ideas though.