Add translate function #5212
Merged
Add translate function #5212
+240
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
approved these changes
Nov 5, 2022
Tishj
suggested changes
Nov 5, 2022
| auto codepoint_haystack = Utf8Proc::UTF8ToCodepoint(input_haystack, sz); | ||
| if (to_replace.count(codepoint_haystack) != 0) { | ||
| Utf8Proc::CodepointToUtf8(to_replace[codepoint_haystack], c_sz, c); | ||
| result.insert(result.end(), c, c + c_sz); |
There was a problem hiding this comment.
I believe we can make a pretty decent estimation as to what the size of result will be, can we add a result.reserve(..) to this before this loop?
There was a problem hiding this comment.
You're right. Reserve a enough size for the result to avoid allocate memory frequently.
Tishj
approved these changes
Nov 6, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It supports unicode. #5156