Use structs to avoid confusing C pointer wrappers #4961
Merged
+59
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I think this is a good idea, as long as it can be done in a portable manner that does not break any of the builds. |
93c69d9 to
b05ebf5
Compare
|
Tests seem much better now, the failure in the extension test seems to be an internet outage. |
|
Yea that failure is fixed by a recent PR that changes pulling openssl from github instead of the old source |
Mytherin
reviewed
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on ADBC, a bit of time was lost because those pointers were used incorrectly. This PR uses pointers to anonymous
structs instead of plainvoidpointers, avoiding the following error kinds:duckdb_databasevs.duckdb_connectionduckdb_databasevs.duckdb_database*If we agree that this (or a similar approach) is useful, I can proceed with securing the four remaining typedefs which currently break the build.