Skip to content

Conversation

lokax
Copy link
Contributor

@lokax lokax commented Jul 31, 2022

Maybe fix #4252 #4258

@Mytherin
Copy link
Collaborator

Thanks for the PR! Could you perhaps add the test from the issue, and verify locally that this actually fixes the issue?

@lokax
Copy link
Contributor Author

lokax commented Jul 31, 2022

Thanks for the PR! Could you perhaps add the test from the issue, and verify locally that this actually fixes the issue?

I have a simpler example than the issue. Let me add it.

@Mytherin
Copy link
Collaborator

Could you add the test from the issue as well to verify that it is fixed?

@lokax
Copy link
Contributor Author

lokax commented Jul 31, 2022

Could you add the test from the issue as well to verify that it is fixed?

#4258 Make the test results of the issue 4252 inconsistent

@lokax
Copy link
Contributor Author

lokax commented Jul 31, 2022

I modified the original query in the test code.
WHERE CAST(day AS DATE) >= '2022-01-01 00:00:00' --> WHERE day >= CAST('2022-01-01 00:00:00' AS DATE).
Because if issue 4258 is fixed, the original query will not get the expected result.

@Mytherin
Copy link
Collaborator

Mytherin commented Aug 1, 2022

Thanks for the updates! Looks good to me.

@Mytherin Mytherin merged commit e95fb4c into duckdb:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full outer join returning more rows than expected
2 participants