-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
Description
What happens?
R doesn't like when bundled libraries use functions like rand()
and srand()
. The skiplist refers to those, but apparently the functions they are used in are never used themselves.
Is it safe to remove those functions? Can we do it here (preferred) or through a patching mechanism in the R package?
To Reproduce
- https://github.com/duckdb/duckdb-r/actions/runs/7160751273/job/19495456017?pr=51#step:12:207: NOTE from
R CMD check
- duckdb/duckdb-r@
2ad3324
(#51): Commit that removes the offending code without further consequences
OS:
Ubuntu 22.04
DuckDB Version:
DuckDB Client:
Core
Full Name:
Kirill Müller
Affiliation:
cynkra GmbH
Have you tried this on the latest main
branch?
I have tested with a main build
Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?
- Yes, I have