Skip to content

Misleading error message appender - not all columns appended #13941

@shoffmeister

Description

@shoffmeister

What happens?

When using the appender (https://duckdb.org/docs/api/c/appender) and when appending an insufficient number of columns, an error is raised.

The text of the error message thrown

InvalidInputException("Call to EndRow before all rows have been appended to!");

appears to be misleading, though, as it talks about rows, when columns are missing. It may be preferable to have

InvalidInputException("Call to EndRow before all columns have been appended to!");

or even

InvalidInputException("Call to EndRow before all columns of the row have been appended!");

For reference, see https://github.com/duckdb/duckdb-java/blob/966fb56335a931b651901eb30e6fb38e32f21f73/src/duckdb/src/main/appender.cpp#L114

To Reproduce

Run an appender which does not append enough columns.

OS:

Arch Linux x86_64

DuckDB Version:

1.1.0

DuckDB Client:

C / Java

Hardware:

No response

Full Name:

Stefan Hoffmeister

Affiliation:

none

What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

I have tested with a stable release

Did you include all relevant data sets for reproducing the issue?

Yes

Did you include all code required to reproduce the issue?

  • Yes, I have

Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?

  • Yes, I have

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions