Skip to content

We are missing bool Time::TryFromTime(hh, mm, ss, us, off, result) #11518

@hawkfish

Description

@hawkfish

Unfortunately we are missing bool Time::TryFromTime(hh, mm, ss, us, off, result), so this will not fail if the time is invalid. I think we need to move this duplicated code into time.cpp and add a call to IsValidTime at the end. Among other things I'm seeing that the parsing code for timestamps does not accept 24:00:00, which is valid. This may be more than you bargained for, so unless you want to wade in deeper, this is fine for now.

Originally posted by @hawkfish in #11516 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions