-
|
I am using duckdb 0.6.0 with downloaded augmentated source in MSVC (from https://github.com/duckdb/duckdb/releases/download/v0.6.0/libduckdb-src.zip). Do you have any idea what this means and how I can get further? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 8 replies
-
|
Hi @annnei, I think I might have a fix for this, could you try to reproduce the same workflow with the using the libduckdb-src.zip that you find inside this zip file (duckdb-binaries-linux)? (this is a temporary artefact I generated, with a minor modification on top of current master, question is whether merging has any use) Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Official line on this is "somewhere in February" |
Beta Was this translation helpful? Give feedback.
-
|
Tried v0.7.0 now, and had to add decimal_separator as a last argument to the template argument list to make it compile. commit 93d8f69 |
Beta Was this translation helpful? Give feedback.
-
|
This is not great, and you are right on where the problem lies. Feel free to file a PR, or I can do it tomorrow. We should probably set up a CI run to fail on this, so that we can catch problem like this during development. |
Beta Was this translation helpful? Give feedback.
-
|
Another side effect that I noticed just now is that duckdb no longer compiles with the slightly older VS version v17.2.6. Haven't looked at what that is yet. I can make a PR for the IntegerCastLoop tomorrow but have no more time today. |
Beta Was this translation helpful? Give feedback.
-
|
While doing this I learned that it is much faster to use the full source than to compile from the amalgamation version. And with the full source I don't seem to see the MSVC compiler issue. So I'll see if it is an option to compile from a tagged source version rather than from downloaded amalgamation. |
Beta Was this translation helpful? Give feedback.
Hi @annnei, I think I might have a fix for this, could you try to reproduce the same workflow with the using the libduckdb-src.zip that you find inside this zip file (duckdb-binaries-linux)?
(this is a temporary artefact I generated, with a minor modification on top of current master, question is whether merging has any use)
Thanks!