You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I often feel confused what's the difference between these two interfaces, after checking the implementation, I find one of them affects file offset, another doesn't.
I would like to know if it's possible to rename (add a new interface and mark deprecation) one of them to PRead, which aligns with operating system's definition.
At least I'm wondering if we could add some documentation on interface behavior at least, I tried to make a PR: #15937
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Here we have multiple
Read
interfaces for FileSystem:duckdb/src/include/duckdb/common/file_system.hpp
Line 60 in e70015a
duckdb/src/include/duckdb/common/file_system.hpp
Line 62 in e70015a
I often feel confused what's the difference between these two interfaces, after checking the implementation, I find one of them affects file offset, another doesn't.
I would like to know if it's possible to rename (add a new interface and mark deprecation) one of them to
PRead
, which aligns with operating system's definition.At least I'm wondering if we could add some documentation on interface behavior at least, I tried to make a PR: #15937
Beta Was this translation helpful? Give feedback.
All reactions