Support running with older C++ stdlib #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cddae0 to
843d735
Compare
This change adds `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` flag for Windows builds that prevents crashes when the host process, into which the ODBC driver is loaded, is run using older versions of C++ stdlib. Details: duckdb/duckdb#17991 Testing: additional test run added that uses `msvcp140.dll` from VS2019 instead of the system-provided one.
843d735 to
ee23cbd
Compare
|
Useful change! Thanks :) |
staticlibs
added a commit
to staticlibs/duckdb-odbc
that referenced
this pull request
Jul 3, 2025
This is a backport of the PR duckdb#169 to `v1.3-ossivalis` stable branch. This change adds `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` flag for Windows builds that prevents crashes when the host process, into which the ODBC driver is loaded, is run using older versions of C++ stdlib. Details: duckdb/duckdb#17991 Testing: additional test run added that uses `msvcp140.dll` from VS2019 instead of the system-provided one.
staticlibs
added a commit
that referenced
this pull request
Jul 3, 2025
This is a backport of the PR #169 to `v1.3-ossivalis` stable branch. This change adds `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` flag for Windows builds that prevents crashes when the host process, into which the ODBC driver is loaded, is run using older versions of C++ stdlib. Details: duckdb/duckdb#17991 Testing: additional test run added that uses `msvcp140.dll` from VS2019 instead of the system-provided one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTORflag for Windows builds that prevents crashes when the host process, into which the ODBC driver is loaded, is run using older versions of C++ stdlib.Details: duckdb/duckdb#17991
Testing: additional test run added that uses
msvcp140.dllfrom VS2019 instead of the system-provided one.