Security update: upgrade to ruzstd v0.7.3 #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we increase the MSRV to 1.81? |
Security update RUSTSEC-2024-0400: ruzstd uninit and out-of-bounds memory reads KillingSpark/zstd-rs#75
blyxxyz
approved these changes
Jan 2, 2025
|
For security fixes it's best not to bump the MSRV unless we have to, to make it as easy as possible for people to update. I'm still not really sure what to do with MSRVs beyond that. If a dependency forces it then that's a good enough reason. It's nice that our current MSRV is supported by old Ubuntu releases but I don't know how many users that actually helps. I don't know any compelling reasons to bump it right now but maybe we don't have to be so strict about it, IDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security update
RUSTSEC-2024-0400: ruzstd uninit and out-of-bounds memory reads
KillingSpark/zstd-rs#75